snapshot engine: fix #416 (remove the hardcoding) and #433 (add url in metadata) #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasochem
changed the title
nicolasochem
changed the title
harryttd
requested changes
May 5, 2022
There was a problem hiding this comment.
Great PR :)
- I'm assuming this is tested works?
- Do we want to make deploying a website optional? That might be too much work right now. I'm not sure.
- A user may not want a custom domain for their site and might just want to use a raw url to the bucket. Do we want to handle this now?
Comment on lines
+566
to
+571
| cat <<EOF >> _config.yml | ||
| remote_theme: ${JEKYLL_REMOTE_THEME_REPOSITORY} | ||
| plugins: | ||
| - jekyll-remote-theme | ||
| EOF | ||
|
|
There was a problem hiding this comment.
I can't leave a comment on line 541 as it isn't part of the diff, but config should be removed from the comment.
There was a problem hiding this comment.
sorry i missed line 575 also. has xtz-shots.io.
harryttd
approved these changes
May 6, 2022
Now yes. It's deployed on ithaca-shots. Here is the new metadata:
No, let's defer until we are actually trying to deploy without a website. Thanks for approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing the little bit of leftover work from the snapshotEngine merge:
snapshotEngine should be totally separate from xtz-shots since anyone can deploy their own. So, all the xtz-shots specific stuff should be hosted on the xtz-shots-website repo, and the snapshotEngine should grab whatever it needs to build the static page.
This is done in this PR. We no longer have a _config.yml in the tezos-k8s repository: we now grab it from xtz-shots-website and append the remote theme config to it with a heredoc.... not super slick but it does the job.
The advantage is that we no longer have to modify config.yml here whenever there is some change in the website metadata (for example, the list of networks on the top right of the page used to say "hangzhounet" despite us having removed it from xtz-shots-website. no longer).
The only leftover references to xtz-shots website are the commented out values in values.yaml (because of course, anyone who would want to deploy a snapshot website should still look into ours to understand how it works)
The only leftover files are Gemfile and Gemfile.lock which I think is ok.
I am also adding full URL to the metadata, this way operators can simply 1. query the metadata 2. parse the url and and 3. download the snapshot